Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capabilities to container security context #109

Merged

Conversation

VenkataChalla554
Copy link
Contributor

@VenkataChalla554 VenkataChalla554 commented Jul 3, 2024

Context

Added security context for container

Changes proposed in this pull request

Added security context capabilities for container

Guidance to review

Deployed review app on cluster2 it is working with out any issues (https://github.com/DFE-Digital/register-trainee-teachers/tree/1890-security-aks-container-hardening-capabilities-test)

After merging

After deployment , this changes can be verified as below.

` kubectl -n development get po register-2222-5994967dbd-x7mxh -o jsonpath='{.spec.containers[*].securityContext}'

{"allowPrivilegeEscalation":false,"capabilities":{"add":["NET_BIND_SERVICE"],"drop":["ALL"]},"privileged":false,"readOnlyRootFilesystem":false,"runAsNonRoot":false,"seccompProfile":{"type":"RuntimeDefault"}}

`

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@VenkataChalla554 VenkataChalla554 force-pushed the 1890-security-aks-container-hardening-capabilities branch from 88aca13 to fd045af Compare July 3, 2024 14:58
@VenkataChalla554 VenkataChalla554 marked this pull request as ready for review July 3, 2024 15:16
@VenkataChalla554
Copy link
Contributor Author

@VenkataChalla554 VenkataChalla554 force-pushed the 1890-security-aks-container-hardening-capabilities branch from fd045af to 9869533 Compare July 4, 2024 08:51
@VenkataChalla554 VenkataChalla554 changed the title Added security context for container Added capabilities to container security context Jul 4, 2024
@VenkataChalla554 VenkataChalla554 merged commit d74e687 into main Jul 4, 2024
3 checks passed
@VenkataChalla554 VenkataChalla554 deleted the 1890-security-aks-container-hardening-capabilities branch July 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants