[1750] Fix environment_domains linting issues #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
force-pushed
the
1750-claim-create-zone-in-s189
branch
from
b9b450c to
40aab49
Compare
saliceti
force-pushed
the
1750-claim-create-zone-in-s189
branch
2 times, most recently
from
eba7bd7 to
98e32e8
Compare
- Fix redirect_rules default value - Fix string interpolations
saliceti
force-pushed
the
1750-claim-create-zone-in-s189
branch
from
98e32e8 to
24f3105
Compare
VenkataChalla554
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
redirect_rules is a list of maps, but the default value is an empty map. It may cause issues if it's used.
Changes proposed in this pull request
Guidance to review
Use the 1750-claim-create-zone-in-s189 branch in terrafile and try with/without redirect rule (tested on claims: DFE-Digital/claim-additional-payments-for-teaching#2953)
Checklist
Devopslabel