SSL mode value set based in use_azure flag #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
reviewed
Jul 1, 2024
saliceti
reviewed
Jul 1, 2024
VenkataChalla554
force-pushed
the
1813-standardise-logging-fields
branch
from
4280d3c to
4c0da0b
Compare
VenkataChalla554
force-pushed
the
1813-standardise-logging-fields
branch
from
4c0da0b to
b91199b
Compare
saliceti
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Removed hard code value of SSL Mode.
Changes proposed in this pull request
SSL Mode Value set based on user_azure.
Guidance to review
Deployed review app using this branch : https://github.com/DFE-Digital/teaching-record-system/tree/1813-standardise-logging-terraform-module-test.
make dv_review terraform-apply CLUSTER=cluster2 IMAGE=ghcr.io/dfe-digital/teaching-record-system:b96c149d3b2db5f4ce4ddb29928cfec6af0e286a APP_NAME=2222
Checklist
Devopslabel