Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft delete for storage backup #100

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

johnake
Copy link
Contributor

@johnake johnake commented Jun 10, 2024

Context

To prevent accidental or malicious deletion, we need to add soft delete to storage accoun

Changes proposed in this pull request

Add soft delete to terraform-modules/aks/postgres/resources.tf at main · DFE-Digital/terraform-modules
i.e. add a delete_retention_policy of 7 days for blobs and containers

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@johnake johnake added the devops label Jun 10, 2024
@johnake
Copy link
Contributor Author

johnake commented Jun 10, 2024

@johnake johnake merged commit 096521d into main Jun 10, 2024
3 checks passed
@johnake johnake deleted the 1830-security-soft-delete-for-backup-storage-accounts branch June 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants