disable test that only works if run too quickly #7319
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starswan
force-pushed
the
mark-broken-test-pending
branch
from
a656b34
to
826a82b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Turns out this test only only passes if run really quickly. All notifications (including invisible ones) are marked as read when the first page is viewed. This has been present since June 2021, so I guess it's not a very important bug to fix.
This changes fixes the test (by waiting for the page to change) at which point the defective code fails 100% of the time
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?