Fix Ventrus school mapping #7293
Merged
+95
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the existing code when no school URN comes from Ventrus feed. Our system assings the vacancy to the first Organisation found with "nil" urn value. So the Ventrus vacancy ends assigned to a random MAT/SchoolGroup (that has no URN value). To fix it, we are: - Ensuring that the correct trust ID must be provided by Ventrus feed. - Only assigning the vacancy to a particular school if the URN is provided and belongs to a school that is part of Ventrus. - When no/incorrect school urn is provided, it assigns it to Ventrust trust itself, not to a particular school.
ddippolito
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the existing code when no school URN comes from Ventrus feed. Our system assigns the vacancy to the first Organisation found with "nil" urn value.
So the Ventrus vacancy ends assigned to a random MAT/SchoolGroup (that has no URN value).
To fix it, we are: