[937] Enable Azure RBAC authentication to AKS #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
requested review from
Lockyy,
leoapost,
peteryates,
javier-npq and
slawosz
as code owners
Also remove azure credentials for terraform as they are provided by set-kubelogin-environment
saliceti
force-pushed
the
937-enable-azure-rbac-deployment
branch
from
5c050fd to
a7a0a5e
Compare
|
Review app deployed to https://cpd-tsh-review-86.test.teacherservices.cloud/ |
|
Closing for testing |
|
Closing for retesting |
|
Closing for reretesting |
saliceti
force-pushed
the
937-enable-azure-rbac-deployment
branch
from
a358aaa to
1d44d4e
Compare
|
Closing for rereretesting |
cwrw
reviewed
Jan 31, 2024
cwrw
approved these changes
Jan 31, 2024
slawosz
approved these changes
Feb 1, 2024
leoapost
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://trello.com/c/3m8PNLG6
The AKS clusters will be migrated to Azure RBAC and the authentication need to change.
Changes proposed in this pull request