Devops #71
Merged
Devops #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawosz
requested review from
Lockyy,
leoapost,
peteryates and
javier-npq
as code owners
peteryates
reviewed
Sep 22, 2023
Dockerfile
Outdated
Comment on lines
75
to
76
| CMD RAILS_ENV=production bundle exec rails db:migrate && \ | ||
| RAILS_ENV=production bundle exec rails server -b 0.0.0.0 |
There was a problem hiding this comment.
Suggested change
| CMD RAILS_ENV=production bundle exec rails db:migrate && \ | |
| RAILS_ENV=production bundle exec rails server -b 0.0.0.0 | |
| CMD RAILS_ENV=${RAILS_ENV} bundle exec rails db:migrate && \ | |
| RAILS_ENV=${RAILS_ENV} bundle exec rails server -b 0.0.0.0 |
peteryates
reviewed
Sep 22, 2023
slawosz
force-pushed
the
devops
branch
2 times, most recently
from
a566ab6 to
8d8524c
Compare
peteryates
reviewed
Sep 27, 2023
peteryates
reviewed
Sep 27, 2023
RMcVelia
reviewed
Sep 28, 2023
| "cluster": "test", | ||
| "namespace": "cpd-development", | ||
| "environment": "development", | ||
| "deploy_azure_backing_services": false, |
There was a problem hiding this comment.
We normally use azure backing services for permanent envs. i.e. dev, staging, production. And then set deploy_azure_backing_services to false for review environments only.
Makefile
Outdated
| terraform -chdir=terraform/application init -upgrade -reconfigure \ | ||
| -backend-config=resource_group_name=${RESOURCE_GROUP_NAME} \ | ||
| -backend-config=storage_account_name=${STORAGE_ACCOUNT_NAME} \ | ||
| -backend-config=key=${ENVIRONMENT}_kubernetes.tfstate |
There was a problem hiding this comment.
this won't work with review apps. Something like
$(if $(PULL_REQUEST_NUMBER), $(eval KEY_PREFIX=$(PULL_REQUEST_NUMBER)), $(eval KEY_PREFIX=$(ENVIRONMENT)))
then
-backend-config=key=${KEY_PREFIX}_kubernetes.tfstate
slawosz
force-pushed
the
devops
branch
3 times, most recently
from
b082d64 to
bafe313
Compare
saliceti
reviewed
Sep 28, 2023
saliceti
reviewed
Sep 28, 2023
slawosz
commented
Sep 28, 2023
slawosz
commented
Sep 28, 2023
slawosz
force-pushed
the
devops
branch
5 times, most recently
from
3f8fe2e to
d02632e
Compare
|
Review app deployed to https://cpd-tsh-review-71.test.teacherservices.cloud/ |
peteryates
reviewed
Oct 27, 2023
peteryates
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DfE CPD standard scripts with 4 environments: review, staging, sandbox and production.