Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hubs data #215

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix the hubs data #215

merged 1 commit into from
Sep 24, 2024

Conversation

leoapost
Copy link
Contributor

Context

Ticket: N/A

Hubs are not appearing in the search results due to incorrect formatting in the hubs.csv file.

Changes proposed in this pull request

  • Use the ; to separate the hub areas
  • Remove unnecessary spaces

Copy link

Review app deployed to https://cpd-tsh-review-215.test.teacherservices.cloud/

Copy link
Member

@peteryates peteryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted.

Could we do anything to help avoid this if someone refreshes the data at some point too?

@leoapost
Copy link
Contributor Author

@peteryates we manually verify that the data is correctly imported in local dev environments before pushing updates, but issues like this one can be hard to detect. We could add a check that raises an exception whenever a comma is found in the ‘Areas’ field.

@leoapost leoapost added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 68ff450 Sep 24, 2024
9 checks passed
@leoapost leoapost deleted the hubs-data branch September 24, 2024 10:18
@peteryates
Copy link
Member

That sounds like a good idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants