Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: now using keyed services #167

Merged
merged 2 commits into from
Oct 7, 2024

chore: ran cleanup on new code

ef539f8
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Feat: now using keyed services #167

chore: ran cleanup on new code
ef539f8
Select commit
Loading
Failed to load commit list.
GitHub Actions / DotNET Tests succeeded Oct 7, 2024 in 1s

66 passed, 0 failed and 0 skipped

Tests passed successfully

✅ tests/Dfe.ContentSupport.Web.Tests/TestResults/test-results.trx

66 tests were completed in 3s with 66 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Dfe.ContentSupport.Web.Tests.Controllers.CacheControllerTests 1✅ 94ms
Dfe.ContentSupport.Web.Tests.Controllers.ContentControllerTests 6✅ 234ms
Dfe.ContentSupport.Web.Tests.Controllers.SitemapControllerTests 2✅ 328ms
Dfe.ContentSupport.Web.Tests.Exceptions.ContentNotFoundExceptionTests 1✅ 2ms
Dfe.ContentSupport.Web.Tests.Extensions.DateTimeExtensionsTests 1✅ 23ms
Dfe.ContentSupport.Web.Tests.Extensions.WebApplicationBuilderExtensionsTests 3✅ 637ms
Dfe.ContentSupport.Web.Tests.Http.ContentfulServiceTests 1✅ 205ms
Dfe.ContentSupport.Web.Tests.Http.StubContentfulClientTests 1✅ 70ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomAccordionTests 1✅ 54ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomAttachmentTests 1✅ 2ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomCardTests 1✅ 1ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomGridContainerTests 1✅ 2ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.CsTextTests 2✅ 2ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.EmbeddedAssetTests 3✅ 6ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.EmbeddedEntryTests 1✅ 24ms
Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.HyperlinkTests 2✅ 3ms
Dfe.ContentSupport.Web.Tests.Services.ContentServiceTests 15✅ 69ms
Dfe.ContentSupport.Web.Tests.Services.LayoutServiceTests 15✅ 35ms
Dfe.ContentSupport.Web.Tests.Services.ModelMapperTests 8✅ 7ms

✅ Dfe.ContentSupport.Web.Tests.Controllers.CacheControllerTests

✅ Clear_Calls_CacheClear

✅ Dfe.ContentSupport.Web.Tests.Controllers.ContentControllerTests

✅ Error_Returns_ErrorView
✅ Index_Calls_Service_GetContent
✅ Index_ExceptionThrown_ReturnsErrorAction
✅ Index_NoSlug_Returns_ErrorAction
✅ Index_NullResponse_ReturnsErrorAction
✅ Index_WithSlug_Returns_View

✅ Dfe.ContentSupport.Web.Tests.Controllers.SitemapControllerTests

✅ Sitemap_Calls_Returns_ContentResult_XmlModel
✅ Sitemap_Calls_Service_GenerateSitemap

✅ Dfe.ContentSupport.Web.Tests.Exceptions.ContentNotFoundExceptionTests

✅ Exception_Generates_Expected

✅ Dfe.ContentSupport.Web.Tests.Extensions.DateTimeExtensionsTests

✅ ToLongString_Formats_Returns_Expected

✅ Dfe.ContentSupport.Web.Tests.Extensions.WebApplicationBuilderExtensionsTests

✅ Builder_Contains_Correct_Services
✅ Builder_Default_Uses_DefaultClient
✅ Builder_E2e_Uses_MockClient

✅ Dfe.ContentSupport.Web.Tests.Http.ContentfulServiceTests

✅ Client_Calls_Contentful_And_Bounce

✅ Dfe.ContentSupport.Web.Tests.Http.StubContentfulClientTests

✅ Client_Get_MockContent

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomAccordionTests

✅ MapCorrectly

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomAttachmentTests

✅ MapCorrectly

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomCardTests

✅ MapCorrectly

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Custom.CustomGridContainerTests

✅ MapCorrectly

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.CsTextTests

✅ BoldMapsCorrectly
✅ NotBoldMapsCorrectly

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.EmbeddedAssetTests

✅ ImageMapsCorrectly
✅ UnknownMapsCorrectly
✅ VideoMapsCorrectly

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.EmbeddedEntryTests

✅ MapsCorrectly

✅ Dfe.ContentSupport.Web.Tests.Models.Mapped.Standard.HyperlinkTests

✅ IsVimeoMapsCorrectly
✅ NotVimeoMapsCorrectly

✅ Dfe.ContentSupport.Web.Tests.Services.ContentServiceTests

✅ GenerateSitemap_Should_Generate_Expected
✅ GetContent_Calls_Cache_Correct_Key
✅ GetContent_Calls_Client_Once
✅ GetContent_EmptyResponse_Returns_Null
✅ GetContent_Returns_First_Result
✅ GetContentSupportPages_Calls_Cache_Correct_Key
✅ GetContentSupportPages_GotCache_Returns_Cache
✅ GetContentSupportPages_NotGotCache_AddsToCache
✅ GetContentSupportPages_NotGotCache_Calls_Client
✅ GetCsPage_Calls_Cache_Correct_Key
✅ GetCsPages_Calls_Client_Once
✅ GetCsPages_NotPreview_Calls_AddCache_Correct_Key
✅ GetCsPages_NotPreview_Calls_Cache_Correct_Key
✅ GetCsPages_Preview_Calls_AddCache_Correct_Key
✅ GetCsPages_Preview_Calls_Cache_Correct_Key

✅ Dfe.ContentSupport.Web.Tests.Services.LayoutServiceTests

✅ GenerateVerticalNavigation_PageNameDoesNotMatch_ReturnsMenuItemsWithFirstActive
✅ GenerateVerticalNavigation_PageNameMatches_ReturnsCorrectMenuItems
✅ GetHeading_NoPage_ReturnsParentHero
✅ GetHeading_Page_DontUseParent_ReturnsParentHero
✅ GetHeading_Page_UseParent_ReturnsParentHero
✅ GetHeading_PageDoesNotExist_ReturnsParentHero
✅ GetHeading_PageExists_ReturnsCorrectHeading
✅ GetNavigationUrl_EmptyUrl_ReturnsEmptyString
✅ GetNavigationUrl_ExactlyTwoSegments_ReturnsAllSegments
✅ GetNavigationUrl_FewerThanTwoSegments_ReturnsAllSegments
✅ GetNavigationUrl_MoreThanTwoSegments_ReturnsFirstTwoSegments
✅ GetVisiblePageList_ContentListIsEmpty_ReturnsEmptyList
✅ GetVisiblePageList_PageNameIsNullOrEmpty_ReturnsFirstItem
✅ GetVisiblePageList_PageNameProvidedAndDoesNotMatch_ReturnsEmptyList
✅ GetVisiblePageList_PageNameProvidedAndMatches_ReturnsMatchingItems

✅ Dfe.ContentSupport.Web.Tests.Services.ModelMapperTests

✅ BasicComponentReturned
✅ ConvertEntryToContentItem_IsRichText_Returns_RichTextContentItem
✅ ConvertEntryToContentItem_NotRichText_NotReturns_RichTextContentItem
✅ Document_Returns_Null
✅ MapRichTextNodes_NullNode_Returns_UnknownItem
✅ MapToCsPages_Return_Correct_Amount
✅ Unknown_Returns_Unknown
✅ UnknownCustom_Returns_Null