Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(print): Move Javascript to <script> element due to CSP #148

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(print): Move Javascript to <script> element due to CSP #148

merged 1 commit into from
Aug 28, 2024

Conversation

jimwashbrook
Copy link
Collaborator

The print button wasn't working when hosted on PT, due to the content security policy.

This PR:

  1. Removes the in-line window.print() functionality
  2. Moves it to a separate script element, with a nonce (to pass the CSP)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jimwashbrook jimwashbrook mentioned this pull request Aug 27, 2024
Merged
@jimwashbrook jimwashbrook merged commit 132bd08 into Development Aug 28, 2024
3 checks passed
@jimwashbrook jimwashbrook deleted the fix/print-page-csp branch August 28, 2024 08:57
@jimwashbrook jimwashbrook mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iain-Stanger Iain-Stanger Iain-Stanger approved these changes

@ThomasWhittington ThomasWhittington ThomasWhittington approved these changes

@simonjfirth simonjfirth Awaiting requested review from simonjfirth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimwashbrook @ThomasWhittington @Iain-Stanger