Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GovUk.Frontend.AspNetCore from 1.5.0 to 2.0.0 in /src/ServiceAssessmentService #282

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 3, 2024

Bumps GovUk.Frontend.AspNetCore from 1.5.0 to 2.0.0.

Release notes

Sourced from GovUk.Frontend.AspNetCore's releases.

v2.0.0

Targets GOV.UK Frontend v5.1.0.

New features

GOV.UK Frontend hosting options

Previously the GOV.UK Frontend library's assets were always hosted at the root of the application. Many applications generate their own CSS and/or JavaScript bundles and don't need the standard versions at all, though they likely still need the static assets (fonts, images etc.). There are now two properties on GovUkFrontendOptions to control the hosting of the static assets and the compiled assets - StaticAssetsContentPath (default /assets) and CompiledContentPath (default /govuk), respectively. Applications that build and reference their own CSS and JavaScript can set CompiledContentPath to null to skip hosting the standard compiled assets. Similarly, setting StaticAssetsContentPath to null will skip hosting the static assets.

Page template

PageTemplateHelper and the _GovUkPageTemplate.cshtml view have been updated to respect the StaticAssetsContentPath and CompiledContentPath paths set on GovUkFrontendOptions.

An additional ViewData key can now be passed to _GovUkPageTemplate.cshtml - AssetPath. When specified, it will be used in place of the StaticAssetsContentPath value from GovUkFrontendOptions for referencing static asserts.

GovUkFrontendJsEnabledScript, GovUkFrontendScriptImports and GovUkFrontendStyleImports extension methods have been added over IHtmlHelper that wrap the GenerateJsEnabledScript, GovUkFrontendScriptImports and GovUkFrontendStyleImports methods on PageTemplateHelper, respectively.

Tag helper changes

bool tag helper properties have been changed to bool?. This is so that it's possible to differentiate between properties that have been explicitly initialized and those that have been left at the default values. With this, other tag helpers or tag helper initializers can be created that assign default values to these properties.

Breaking changes

AddImportsToHtml

This option was used to automatically add style and JavaScript imports to all Razor views. PageTemplateHelper and the _GovUkPageTemplate.cshtml layout view are better ways to generate a full page template now so this option, along with the backing tag helper component, have been removed.

Fixes

Page template

The og:image meta tag in the _GovUkPageTemplate.cshtml view is now an absolute URL.

v2.0.0-alpha1

Targets GDS Frontend v5.1.0.

Commits
  • cbba9c0 Restore DefaultButtonPreventDoubleClick option
  • 23a3141 Regenerate component images for docs
  • 9aa84e0 Add extension methods over IHtmlHelper for style and script imports
  • 21dbbbd Remove redundant parameter
  • f54477d Fix PageTemplateHelper.GovUkFrontendVersion and add a test for it
  • f1159b3 Use the RepoRoot msbuild property for determining where images go
  • 2fd74da Move HtmlContentExtensions to the root namespace
  • 273a2a4 Rename test folder to tests
  • 0765d9d Add CHANGELOG.md
  • cd95410 Remove the Tag Helper Component that adds style and script imports
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [GovUk.Frontend.AspNetCore](https://github.com/gunndabad/govuk-frontend-aspnetcore) from 1.5.0 to 2.0.0.
- [Release notes](https://github.com/gunndabad/govuk-frontend-aspnetcore/releases)
- [Changelog](https://github.com/gunndabad/govuk-frontend-aspnetcore/blob/main/CHANGELOG.md)
- [Commits](gunndabad/govuk-frontend-aspnetcore@v1.5.0...v2.0.0)

---
updated-dependencies:
- dependency-name: GovUk.Frontend.AspNetCore
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels May 3, 2024
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor Author

dependabot bot commented on behalf of github May 10, 2024

Superseded by #287.

@dependabot dependabot bot closed this May 10, 2024
@dependabot dependabot bot deleted the dependabot/nuget/src/ServiceAssessmentService/GovUk.Frontend.AspNetCore-2.0.0 branch May 10, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants