Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/setup-node from 4.0.0 to 4.0.1 #133

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Bump actions/setup-node from 4.0.0 to 4.0.1
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v4.0.0...v4.0.1)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
dependabot[bot] authored Dec 18, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 9d7bdb10195f3cbf9b0792210f4565b7578f443c
2 changes: 1 addition & 1 deletion .github/workflows/azure-webapps-dotnet-core.yml
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ jobs:
dotnet-version: ${{ env.DOTNET_VERSION }}

- name: Setup Node.js environment
uses: actions/[email protected].0
uses: actions/[email protected].1
with:
## NOTE: dfe-frontend-alpha advertises requirement of node 16, with console warnings/errors if using more recent version
node-version: 16
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ jobs:
dotnet-version: ${{ env.DOTNET_VERSION }}

- name: Setup Node.js environment
uses: actions/[email protected].0
uses: actions/[email protected].1
with:
node-version: ${{ env.NODE_VERSION }}


Unchanged files with check annotations Beta

public class HomeController : Controller
{
private readonly ILogger<HomeController> _logger;

Check warning on line 9 in src/ServiceAssessmentService/ServiceAssessmentService.WebApp/Controllers/HomeController.cs

GitHub Actions / build

Remove this unread private field '_logger' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)

Check warning on line 9 in src/ServiceAssessmentService/ServiceAssessmentService.WebApp/Controllers/HomeController.cs

GitHub Actions / build

Remove this unread private field '_logger' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
public HomeController(ILogger<HomeController> logger)
{
public class BookController : Controller
{
private readonly ILogger<BookController> _logger;

Check warning on line 7 in src/ServiceAssessmentService/ServiceAssessmentService.WebApp/Controllers/BookController.cs

GitHub Actions / build

Remove this unread private field '_logger' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)

Check warning on line 7 in src/ServiceAssessmentService/ServiceAssessmentService.WebApp/Controllers/BookController.cs

GitHub Actions / build

Remove this unread private field '_logger' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
public BookController(ILogger<BookController> logger)
{