[7961] Fix dead link from CSV docs to empty template #4928
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also addresses issues with `content-disposition` to ensure that the empty CSV is always served as a download.
stevehook
commented
Jan 9, 2025
| <%= govuk_link_to( | ||
| "Download empty CSV file to add new trainees", | ||
| bulk_update_add_trainees_empty_template_path(format: :csv), | ||
| ) %> |
There was a problem hiding this comment.
Going through the new route/controller rather than serving the file directly allows us to include a content-disposition header that will direct the browser to treat the file correctly (as a download).
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4928 +/- ##
==========================================
+ Coverage 96.11% 96.19% +0.08%
==========================================
Files 745 751 +6
Lines 16069 16172 +103
==========================================
+ Hits 15444 15557 +113
+ Misses 625 615 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The link from the CSV reference docs to the empty CSV template for bulk add trainee is broken (was never implemented).
Also addresses issues with
content-dispositionto ensure that the empty CSV is always served as a download.Changes proposed in this pull request
BulkUpdate::AddTrainees::EmptyTemplatesController#showaction.Guidance to review
Anything missing?
Important business
NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml