[7891] - Adapt stacktrace and exception formatting #4863
Merged
+150
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 752 752
Lines 16204 16207 +3
=======================================
+ Hits 15590 15593 +3
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d-a-v-e
force-pushed
the
7891-investigate-and-fix-high-volume-of-logging-on-register-production-worker
branch
from
9013559 to
b7d2dcb
Compare
d-a-v-e
temporarily deployed
to
productiondata
GitHub Actions
Inactive
d-a-v-e
had a problem deploying
to
productiondata
GitHub Actions
Failure
d-a-v-e
temporarily deployed
to
productiondata
GitHub Actions
Inactive
d-a-v-e
force-pushed
the
7891-investigate-and-fix-high-volume-of-logging-on-register-production-worker
branch
from
7323ac4 to
479e0fa
Compare
d-a-v-e
temporarily deployed
to
productiondata
GitHub Actions
Inactive
d-a-v-e
temporarily deployed
to
productiondata
GitHub Actions
Inactive
d-a-v-e
had a problem deploying
to
productiondata
GitHub Actions
Failure
d-a-v-e
temporarily deployed
to
productiondata
GitHub Actions
Inactive
|
tomtrentham
changed the title
d-a-v-e
force-pushed
the
7891-investigate-and-fix-high-volume-of-logging-on-register-production-worker
branch
from
de34bba to
6498b21
Compare
d-a-v-e
force-pushed
the
7891-investigate-and-fix-high-volume-of-logging-on-register-production-worker
branch
from
eb29507 to
a0a685a
Compare
d-a-v-e
force-pushed
the
7891-investigate-and-fix-high-volume-of-logging-on-register-production-worker
branch
from
248db28 to
3727cc7
Compare
…ing-on-register-production-worker
tomtrentham
approved these changes
Jan 23, 2025
docs/logging.md
Outdated
| # Logging Documentation | ||
|
|
||
| ## Rails Semantic Logger | ||
| We use `rails_semantic_logger` instead of the default Rails logger because it provides enhanced logging capabilities. It solves several problems such as: |
There was a problem hiding this comment.
Suggested change
| We use `rails_semantic_logger` instead of the default Rails logger because it provides enhanced logging capabilities. It solves several problems such as: | |
| We use [`rails_semantic_logger`](https://github.com/reidmorrison/rails_semantic_logger) instead of the default Rails logger because it provides enhanced logging capabilities. It solves several problems such as: |
docs/logging.md
Outdated
| - [Production Logs](https://kibana-uk1.logit.io/s/e9b9162d-0b5e-4362-bed0-8e577f88d06e/app/data-explorer/discover#?_a=(discover:(columns:!(_source),isDirty:!f,sort:!()),metadata:(indexPattern:'filebeat-*',view:discover))&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_q=(filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'filebeat-*',key:kubernetes.container.name,negate:!f,params:!(register-production,register-production-worker),type:phrases,value:'register-production,%20register-production-worker'),query:(bool:(minimum_should_match:1,should:!((match_phrase:(kubernetes.container.name:register-production)),(match_phrase:(kubernetes.container.name:register-production-worker))))))),query:(language:kuery,query:''))) | ||
| - [QA Logs](https://kibana-uk1.logit.io/s/b2876053-0173-44fc-983d-99567292ba31/app/data-explorer/discover#?_a=(discover:(columns:!(kubernetes.container.name,app.message,app.payload.controller,url.path),isDirty:!t,sort:!()),metadata:(indexPattern:'filebeat-*',view:discover))&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-10m,to:now))&_q=(filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'filebeat-*',key:app.name,negate:!t,params:(query:HeartbeatController),type:phrase),query:(match_phrase:(app.name:HeartbeatController))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'filebeat-*',key:kubernetes.container.name,negate:!f,params:!(register-qa,register-qa-worker),type:phrases,value:'register-qa,%20register-qa-worker'),query:(bool:(minimum_should_match:1,should:!((match_phrase:(kubernetes.container.name:register-qa)),(match_phrase:(kubernetes.container.name:register-qa-worker))))))),query:(language:kuery,query:''))) | ||
|
|
||
| **Note:** the two different GUID's used for Prod (production, productiondata) and Test(QA, staging, review apps) |
There was a problem hiding this comment.
Suggested change
| **Note:** the two different GUID's used for Prod (production, productiondata) and Test(QA, staging, review apps) | |
| **Note:** the two different GUID's used for Prod (production, productiondata) and Test (QA, staging, review apps) |
d-a-v-e
deleted the
7891-investigate-and-fix-high-volume-of-logging-on-register-production-worker
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For the last 2 Mondays (since 28 November), when the Dqt::SyncTeachersJob has run on production it has produced a very high volume of log entries (~9 million) which causes issues for our logit quota, and is clearly unnecessary.
Changes proposed in this pull request
Adapts the stack trace and exception formatting