Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename partnership concepts #4788

Closed
wants to merge 17 commits into from
Closed

Rename partnership concepts #4788

wants to merge 17 commits into from

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Dec 20, 2024 •
edited
Loading

Context

Label Meaning
Providers All providers
Training provider A provider that runs ITT training courses
Accredited provider A provider that is accredited by DfE
Training partner The training provider in a provider partnership association
Accredited partner The accredited provider in a provider partnership association
Ratifying partner The Accredited partner that ratifies the course of a Training partner

The wording in specs still needs to be changed.
For example

  scenario 'i can edit accredited providers on the index page' do

Needs to change to accredited partners. This is WIP until all the wording is updated.

Changes proposed in this pull request

Update all the UI labels and text to accurately convey the concepts above.

Guidance to review

Accredited partners V Accredited partnerships

@inulty-dfe inulty-dfe added the deploy A Review App will be created for PRs with this label label Dec 20, 2024
@inulty-dfe
Copy link
Contributor Author

Trello https://trello.com/c/kkQag5QG/338-tech-debt-rename-partnership-concepts

@inulty-dfe inulty-dfe force-pushed the im/338-tech-debt-rename-partnership-concepts branch 2 times, most recently from 161ce2c to a7f4ca0 Compare January 9, 2025 11:52
@inulty-dfe inulty-dfe force-pushed the im/338-tech-debt-rename-partnership-concepts branch from a7f4ca0 to 03ae2ae Compare January 9, 2025 12:09
@inulty-dfe inulty-dfe force-pushed the im/338-tech-debt-rename-partnership-concepts branch from fe564ae to 762e7f0 Compare January 9, 2025 12:46
@inulty-dfe inulty-dfe added deploy A Review App will be created for PRs with this label and removed deploy A Review App will be created for PRs with this label labels Jan 9, 2025
@inulty-dfe
Copy link
Contributor Author

Review app deployment is not working so I'll close this PR and reopen in the hope that it just works

@inulty-dfe inulty-dfe closed this Jan 9, 2025
@github-actions github-actions bot temporarily deployed to review-4808 January 9, 2025 15:03 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inulty-dfe