Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accredited column to Provider #4787

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Dec 19, 2024

Context

This column will replace the accrediting_provider column

The purpose of the accrediting_provider is to denote whether the provider has been given accredited status by DfE.
This column causes frustration for developers.

  • The column is on the provider table and it has a suffix _provider
  • It stores a text value which is one of two values and those values are a single byte each
  • We are confused by accredited_provider, Course#accrediting_provider, Provider#accrediting_provider
  • We don't know whether to use ``Provider.accrediting_provider == 'accredited_provider'orProvider#accredited_provider?`
  • There are tests like this expect(provider.reload.accredited_provider).to eq('not_an_accredited_provider')

Changes proposed in this pull request

Add a new column to replace the accrediting_provider column

Guidance to review

@inulty-dfe inulty-dfe requested a review from a team as a code owner December 19, 2024 14:40
  This column will replace the accrediting_provider column
@inulty-dfe inulty-dfe force-pushed the im/add-accredited-column-to-provider branch from af525b3 to 8bc4cfb Compare January 10, 2025 10:05
@inulty-dfe inulty-dfe merged commit 5ee96ce into main Jan 13, 2025
19 checks passed
@inulty-dfe inulty-dfe deleted the im/add-accredited-column-to-provider branch January 13, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants