Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Im/add routes and controllers for provider partnerships #4767

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Dec 13, 2024

Context

Add the routes, controllers and views required for enabling provider partnerships.

Provider partnerships is the rebuilding of the associations between Lead partners and Accredited providers.

This PR is for testing and feedback. It will likely be merged in incremental PRs

Changes proposed in this pull request

This PR tries to create all the code necessary for the old implementation to be swtiched seamlessly to the new.

  1. Use routing constraint to enable/disable routes
  2. The constraint currently depends on a Settings
  3. Create a v2/Training providers becuase I don't see the name of this model / routing changing? Maybe Training partners in fact
  4. Create a ProviderPartnershipsController
  5. This changes the URL path
  6. The Accredited providers implementation depends on a search box "accredited_provider_search" - it doesn't seem logical to rename this to "provider_partnership_search"
  7. This controller is awkward and requires conditionals to exist while both implementations exist.

Guidance to review

@inulty-dfe inulty-dfe added the deploy A Review App will be created for PRs with this label label Dec 13, 2024
@github-actions github-actions bot temporarily deployed to review-4767 December 13, 2024 17:55 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 13, 2024 18:03 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 13, 2024 18:11 Destroyed
@inulty-dfe inulty-dfe marked this pull request as ready for review December 13, 2024 18:56
@inulty-dfe inulty-dfe requested a review from a team as a code owner December 13, 2024 18:56
@github-actions github-actions bot temporarily deployed to review-4767 December 13, 2024 18:59 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 10:30 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 35c55ac to 448a4e5 Compare December 16, 2024 10:44
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 10:52 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 11:08 Destroyed
@inulty-dfe inulty-dfe marked this pull request as draft December 16, 2024 14:03
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 15:52 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from c9f30ac to 7a2d735 Compare December 16, 2024 15:55
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 15:59 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 17:24 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 17:40 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 19:49 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 8792f31 to 4add6c1 Compare December 16, 2024 20:05
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 20:09 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 20:24 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 16, 2024 20:30 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 17, 2024 10:46 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 986b5b1 to f1e28cf Compare December 17, 2024 16:56
@github-actions github-actions bot temporarily deployed to review-4767 December 17, 2024 16:59 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 18, 2024 09:11 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 18, 2024 09:32 Destroyed
@github-actions github-actions bot temporarily deployed to review-4767 December 18, 2024 12:04 Destroyed
@inulty-dfe inulty-dfe self-assigned this Dec 18, 2024
@github-actions github-actions bot temporarily deployed to review-4767 December 18, 2024 15:20 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 6d35214 to 710a800 Compare December 19, 2024 16:19
@github-actions github-actions bot temporarily deployed to review-4767 December 19, 2024 16:23 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 90d26ed to 089356d Compare December 19, 2024 16:25
@github-actions github-actions bot temporarily deployed to review-4767 December 19, 2024 16:30 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 089356d to 5bb0be2 Compare December 19, 2024 16:34
@github-actions github-actions bot temporarily deployed to review-4767 December 19, 2024 16:44 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from cb28ee7 to 4a2758e Compare December 19, 2024 16:55
  #accredited_bodies is the main way the we retreive a provdiers
  accredited partnerships with enrichments.

  By adding a feature flag switch here we can choose whether to activate
  the new partnership association or the existing enrichment
  association.
@github-actions github-actions bot temporarily deployed to review-4767 December 19, 2024 16:59 Destroyed
  Toggling the provider_partnerships feature flag will be used to make
  available sets of routes in the applicaiton
  include locales, AccreditedPartnershipForm
  Separate validations for when using enrichments v partnerships
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 4a2758e to 811123c Compare December 20, 2024 09:10
@github-actions github-actions bot temporarily deployed to review-4767 December 20, 2024 09:18 Destroyed
@inulty-dfe inulty-dfe force-pushed the im/add-routes-and-controllers-for-provider-partnerships branch from 811123c to 618519a Compare December 20, 2024 09:40
@github-actions github-actions bot temporarily deployed to review-4767 December 20, 2024 09:44 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant