Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accredited provider number / id to Support Provider list #4688

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Nov 15, 2024

Context

It is useful for our team to see which accredited providers are
missing an accredited provider number

Changes proposed in this pull request

Show a providers' accredited Provider number in the support console.

Guidance to review

Review App Support Console

  It is useful for our team to see which accredited providers are
  missing an accredited provider number
@inulty-dfe
Copy link
Contributor Author

@inulty-dfe inulty-dfe added deploy A Review App will be created for PRs with this label deploy_v2 and removed deploy A Review App will be created for PRs with this label labels Nov 15, 2024
@github-actions github-actions bot temporarily deployed to review_aks-4688 November 15, 2024 16:07 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4688 November 15, 2024 16:21 Destroyed
@inulty-dfe inulty-dfe marked this pull request as ready for review November 15, 2024 17:01
@inulty-dfe inulty-dfe requested a review from a team as a code owner November 15, 2024 17:01
@Nitemaeric
Copy link
Contributor

Nitemaeric commented Nov 18, 2024

To reduce the number of columns and give more space, can we combine the "accredited provider?" and "accredited provider number" columns?

If their reference number is missing, we could use a yellow tag instead.

CleanShot 2024-11-18 at 10 27 41@2x

Could possibly use the words "Yes - #{ref_number}" and "Yes - Missing" instead for clarity.

@inulty-dfe inulty-dfe force-pushed the im/add-provider-id-column-to-support-interface branch from b605a63 to 5eb67de Compare November 19, 2024 12:01
@inulty-dfe inulty-dfe added deploy A Review App will be created for PRs with this label and removed deploy_v2 deploy A Review App will be created for PRs with this label labels Nov 19, 2024
@Nitemaeric Nitemaeric merged commit 99bc933 into main Nov 19, 2024
56 of 57 checks passed
@Nitemaeric Nitemaeric deleted the im/add-provider-id-column-to-support-interface branch November 19, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants