-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Teacher Training API to return selectable_school
#4465
Merged
inulty-dfe
merged 4 commits into
main
from
2202-update-publish-api-to-return-selectable-school-as-part-of-the-providers-api
Aug 21, 2024
Merged
Update Teacher Training API to return selectable_school
#4465
inulty-dfe
merged 4 commits into
main
from
2202-update-publish-api-to-return-selectable-school-as-part-of-the-providers-api
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`selectable_school` is a property of a Provider in the TTAPI
The middleman gem uses ruby 2.7 so we build it in the container and copy the output to the public directory
inulty-dfe
force-pushed
the
2202-update-publish-api-to-return-selectable-school-as-part-of-the-providers-api
branch
from
August 21, 2024 08:11
5930629
to
c3cbe6a
Compare
Use the following command to generate OpenAPI specification: | ||
|
||
```sh | ||
bundle exec rake rswag:specs:swaggerize | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command is duplicated below. Both lines execute the same command.
tomas-stefano
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing the duplication in the document, looks good 🚀
CatalinVoineag
approved these changes
Aug 21, 2024
inulty-dfe
deleted the
2202-update-publish-api-to-return-selectable-school-as-part-of-the-providers-api
branch
August 21, 2024 13:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have added a property to Provider,
selectable_school
. We want to provider this property via the API.This property must be documented in the API docs.
Changes proposed in this pull request
selectable_school
to the ProviderAttributes API response.Guidance to review
https://publish-review-4465.test.teacherservices.cloud/docs/#about
API response
API docs
http://publish.localhost:3001/api_docs`
Trello Ticket
Update Publish API to return selectable school as part of the Providers API
Things to check