Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign visa sponsorship on course page #4366

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Jul 11, 2024

Context

The International students section is going to be removed from the
publis/find course show pages. This is part of a redesign of the course
page to make it easier for users to view the information without being
overwhelmed

The visa sponsorship content will now be in a drop-down details tag. The
content inside has also been tweaked.

Changes proposed in this pull request

InternationalStudentsComponent now will display the info in a details tag.

Moved the provider_url helper methods in a more global place.

Guidance to review

View a course on publish and find and open the visa sponsorship dropdown

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Inform data insights team due to database changes
Peek.2024-07-11.16-30.mp4

@CatalinVoineag CatalinVoineag self-assigned this Jul 11, 2024
@CatalinVoineag CatalinVoineag changed the title Wip Redesign visa sponsorship on course page Jul 11, 2024
@CatalinVoineag CatalinVoineag force-pushed the cv/course-visa-sponsorship branch 2 times, most recently from 8bae92f to 5c79e4e Compare July 11, 2024 14:39
@CatalinVoineag
Copy link
Contributor Author

@CatalinVoineag CatalinVoineag force-pushed the cv/course-visa-sponsorship branch from 5c79e4e to 75ffb03 Compare July 11, 2024 15:22
@CatalinVoineag CatalinVoineag marked this pull request as ready for review July 11, 2024 15:23
@CatalinVoineag CatalinVoineag force-pushed the cv/course-visa-sponsorship branch 2 times, most recently from da5d953 to 72eebd4 Compare July 11, 2024 15:27
@CatalinVoineag CatalinVoineag requested review from a team and kelliedesigner July 11, 2024 15:46
@kelliedesigner
Copy link

Looks good to me!

Copy link
Collaborator

@avinhurry avinhurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny formatting thing but no blockers.

Awesome work 💪🏼

config/locales/find.yml Outdated Show resolved Hide resolved
The International students section is going to be removed from the
publis/find course show pages. This is part of a redesign of the course
page to make it easier for users to view the information without being
overwhelmed

The visa sponsorship content will now be in a drop-down details tag. The
content inside has also been tweaked.
@CatalinVoineag CatalinVoineag force-pushed the cv/course-visa-sponsorship branch from 72eebd4 to 3569a39 Compare July 12, 2024 08:44
@CatalinVoineag CatalinVoineag merged commit 7a3bd05 into main Jul 12, 2024
19 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/course-visa-sponsorship branch July 12, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants