Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Radius filter to Search results #4361

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

dcyoung-dev
Copy link
Contributor

@dcyoung-dev dcyoung-dev commented Jul 10, 2024

Context

Filter only displays if the radius parameter is in the URL

Changes proposed in this pull request

Added radius filter to Results view

Guidance to review

Screen.Recording.2024-07-10.at.17.15.43.mov

Trello

https://trello.com/c/Ymct9lT2

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Inform data insights team due to database changes

Filter only displays if the `radius` parameter is in the URL

WIP: This does not have tests for the UI
@dcyoung-dev dcyoung-dev self-assigned this Jul 10, 2024
@dcyoung-dev dcyoung-dev force-pushed the dy-adding-radius-select-on-search-results branch from a34206d to 2fa6795 Compare July 11, 2024 08:43
@dcyoung-dev dcyoung-dev requested a review from a team July 11, 2024 12:29
Comment on lines +206 to +207
one: '%{count} mile'
other: '%{count} miles'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the review app and it works as expected. I think this will be a good improvement for users. Nice work!

@dcyoung-dev dcyoung-dev merged commit 26e843a into main Jul 17, 2024
19 checks passed
@dcyoung-dev dcyoung-dev deleted the dy-adding-radius-select-on-search-results branch July 17, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants