Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[225] Update wording to reflect multiple study sites #4346

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

avinhurry
Copy link
Collaborator

@avinhurry avinhurry commented Jul 8, 2024

Context

Our automated study sites wording on Find does not reflect that a user can have multiple study sites.

Changes proposed in this pull request

Pluralize the word location if the user has multiple study sites.

The whole study sites section is not shown if the user doesn't have any study sites.

Before at all times

image

After with a single study site

image

After with multiple study sites

image

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Inform data insights team due to database changes

@avinhurry
Copy link
Collaborator Author

@avinhurry avinhurry marked this pull request as ready for review July 8, 2024 08:18
@avinhurry avinhurry requested a review from a team July 8, 2024 08:18
@RebeccaCryan
Copy link

Looks good to me, thanks Avin

@avinhurry avinhurry merged commit 5b067f6 into main Jul 8, 2024
38 checks passed
@avinhurry avinhurry deleted the 225-wording-of-study-sites-section-in-find branch July 8, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants