Validating A levels when publishing for teacher degree apprenticeship courses #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to add a validation for the A levels when publishing a course. I added the option render_errors: with default being true to avoid breaking existing code but passing false to A levels Because: * The A levels are a multi step form and I need to inject the error on the row in any way is described in the card * The row has the wizard step name attached to the link so different from the way GCSEs or degrees or others are doing when publishing
tomas-stefano
changed the title
tomas-stefano
commented
Jul 3, 2024
| if fields.any? { |field| @errors&.key? field.to_sym } | ||
| errors = fields.map do |field| | ||
| @errors[field.to_sym]&.map { |error| enrichment_error_link(model, field, error) } | ||
| end.flatten | ||
|
|
||
| value = raw(*errors) | ||
| value = raw(*errors) if render_errors.present? |
There was a problem hiding this comment.
Avoiding the automatic behaviour because on the row, the error message is slightly different on A level since the A levels is the only multi step form in the course description tab. Unfortunately I have to do this to follow the same pattern but avoiding undesirable results.
tomas-stefano
commented
Jul 3, 2024
|
|
||
| return record.errors.add(:accept_pending_a_level, :blank) if record.accept_pending_a_level.nil? | ||
|
|
||
| record.errors.add(:accept_a_level_equivalency, :blank) if record.accept_a_level_equivalency.nil? |
There was a problem hiding this comment.
The validations are sequential (meaning one at a time), so I opt-in to add a custom validator.
|
If you click on the error and goes to the wizard the back links are like if you're navigating within the wizard. I will leave as it is and wait for tomorrow bug party and I will talk with the designer about it. |
elceebee
approved these changes
Jul 3, 2024
|
thank you @elceebee , I appreciate 🙏 |
CatalinVoineag
approved these changes
Jul 3, 2024
tomas-stefano
deleted the
1895-a-level-validation-when-publishing-a-course
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to add a validation for the A levels when publishing a course.
Trello card & Lucid board
https://trello.com/c/BzbwKssS/1895-a-level-validation-when-publishing-a-course
https://lucid.app/lucidspark/ba759696-865b-46b4-ab23-9d3af92d79fb/edit?view_items=ohfKW2nmrz23&invitationId=inv_fa1f4bfe-7a1f-49d1-ae9c-1e46971e8f85
Changes proposed in this pull request
Please see trello card AND the lucid board for more details.
Guidance to review
I added the option render_errors: with default being true to avoid breaking existing code but passing false to A levels Because: