Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.25.0 to 2.25.1 #4321

Merged
merged 2 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ GEM
matrix (0.4.2)
method_source (1.1.0)
mini_mime (1.1.5)
minitest (5.24.0)
minitest (5.24.1)
mock_redis (0.44.0)
msgpack (1.7.2)
multi_json (1.15.0)
Expand Down Expand Up @@ -658,7 +658,7 @@ GEM
rubocop (~> 1.41)
rubocop-factory_bot (2.26.1)
rubocop (~> 1.61)
rubocop-rails (2.25.0)
rubocop-rails (2.25.1)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.33.0, < 2.0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

class ChangeApplicationStartAndEndDateToNotNull < ActiveRecord::Migration[5.2]
def change
# rubocop:disable Rails/BulkChangeTable
change_column_null :recruitment_cycle, :application_start_date, false
change_column_null :recruitment_cycle, :application_end_date, false
# rubocop:enable Rails/BulkChangeTable
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@ def up
pe.updated_by_user_id = some_id
pe.save!
end

# rubocop:disable Rails/BulkChangeTable
change_column_null :provider_enrichment, :updated_by_user_id, false
change_column_null :provider_enrichment, :created_by_user_id, false
# rubocop:enable Rails/BulkChangeTable
end

def down
# rubocop:disable Rails/BulkChangeTable
change_column_null :provider_enrichment, :updated_by_user_id, true
change_column_null :provider_enrichment, :created_by_user_id, true
# rubocop:enable Rails/BulkChangeTable
end
end
2 changes: 2 additions & 0 deletions db/migrate/20210317141543_add_not_null_to_user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

class AddNotNullToUser < ActiveRecord::Migration[6.1]
def change
# rubocop:disable Rails/BulkChangeTable
change_column_null(:user, :first_name, false)
change_column_null(:user, :last_name, false)
# rubocop:enable Rails/BulkChangeTable
end
end
Loading