Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1571] publish cut down course information move school placements to its own page #4236

Merged
merged 4 commits into from
May 31, 2024
Merged

[1571] publish cut down course information move school placements to its own page #4236

merged 4 commits into from
May 31, 2024

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented May 28, 2024 •
edited
Loading

Context

We have split the three sections in the course information page (about this course, interview process and how school placements work) into three different pages. This is the final / third ticket and it cleans up what remains of the course information page, changing it to the 'how school placements work' page.

Trello card

Changes proposed in this pull request

  • Route from course_information to school-placements
  • Content changes per the card
  • Retains the 'copy from another course' funtionality.
  • Retains navigation from preview page
Before After
image image

Guidance to review

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • [NA] Inform data insights team due to database changes

@elceebee elceebee force-pushed the 1573-publish-cut-down-course-information-move-interview-process-to-its-own-page branch from fc761df to f6aa8bc Compare May 29, 2024 12:41
@elceebee elceebee force-pushed the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch from aad1ab1 to 7207cb6 Compare May 29, 2024 13:13
@elceebee elceebee changed the base branch from 1573-publish-cut-down-course-information-move-interview-process-to-its-own-page to main May 29, 2024 13:16
@elceebee elceebee changed the base branch from main to 1573-publish-cut-down-course-information-move-interview-process-to-its-own-page May 29, 2024 13:17
@elceebee elceebee force-pushed the 1573-publish-cut-down-course-information-move-interview-process-to-its-own-page branch 2 times, most recently from bb47784 to d14ea92 Compare May 29, 2024 13:35
@elceebee elceebee force-pushed the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch 2 times, most recently from 6138139 to 2c2522c Compare May 30, 2024 08:36
@elceebee elceebee force-pushed the 1573-publish-cut-down-course-information-move-interview-process-to-its-own-page branch from d87f9ba to 1c38905 Compare May 30, 2024 09:20
@elceebee elceebee force-pushed the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch from 6cbdcdc to 43ffbd2 Compare May 30, 2024 09:20
@elceebee elceebee force-pushed the 1573-publish-cut-down-course-information-move-interview-process-to-its-own-page branch from a9a38fd to 228dfdd Compare May 30, 2024 13:22
Base automatically changed from 1573-publish-cut-down-course-information-move-interview-process-to-its-own-page to main May 30, 2024 13:30
@elceebee elceebee force-pushed the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch 3 times, most recently from ecfa010 to b43ec39 Compare May 30, 2024 15:52
@elceebee elceebee changed the title 1571 publish cut down course information move school placements to its own page [1571] publish cut down course information move school placements to its own page May 30, 2024
@elceebee elceebee marked this pull request as ready for review May 30, 2024 16:08
avinhurry
avinhurry reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@avinhurry avinhurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you submit the form and validation kicks in you lose the content you typed and the form resets to whatever was in the database.

school_placements_bug

app/controllers/publish/courses/school_placements_controller.rb Outdated Show resolved Hide resolved
app/decorators/course_decorator.rb Outdated Show resolved Hide resolved
config/locales/en.yml Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Show resolved Hide resolved
spec/factories/users.rb Show resolved Hide resolved
spec/features/publish/courses/editing_course_school_placements_copy_content_spec.rb Outdated Show resolved Hide resolved
@elceebee elceebee force-pushed the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch from a5f2908 to a3c2073 Compare May 31, 2024 08:48
@elceebee
Copy link
Contributor Author

When you submit the form and validation kicks in you lose the content you typed and the form resets to whatever was in the database.

school_placements_bug school_placements_bug

Fixed, was using the @course value instead of @course_form value.

@elceebee elceebee force-pushed the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch from a3c2073 to a411ff5 Compare May 31, 2024 08:56
@elceebee elceebee force-pushed the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch from a411ff5 to 87af094 Compare May 31, 2024 09:24
@elceebee elceebee merged commit 6d613df into main May 31, 2024
19 checks passed
@elceebee elceebee deleted the 1571-publish-cut-down-course-information-move-school-placements-to-its-own-page branch May 31, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inulty-dfe inulty-dfe inulty-dfe approved these changes

@avinhurry avinhurry avinhurry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elceebee @avinhurry @inulty-dfe