[1576] Move Course Length to its own page #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elceebee
force-pushed
the
1576-publish-cut-down-course-length-fees-page-move-course-length-to-its-own-page
branch
2 times, most recently
from
b50c91b to
3d52680
Compare
elceebee
force-pushed
the
1576-publish-cut-down-course-length-fees-page-move-course-length-to-its-own-page
branch
from
ef921ff to
e864f70
Compare
elceebee
changed the title
elceebee
commented
May 22, 2024
| @@ -24,25 +24,24 @@ | |||
| end | |||
|
|
|||
| context 'copying content from another course' do | |||
| let!(:course2) do | |||
| let!(:biology_course) do | |||
There was a problem hiding this comment.
I had a rubocop failure about using indexes in the let statements (2, 3), so that's why this is changed.
elceebee
force-pushed
the
1576-publish-cut-down-course-length-fees-page-move-course-length-to-its-own-page
branch
from
e864f70 to
ade1bf3
Compare
elceebee
force-pushed
the
1576-publish-cut-down-course-length-fees-page-move-course-length-to-its-own-page
branch
from
6c366ad to
23c445d
Compare
elceebee
deleted the
1576-publish-cut-down-course-length-fees-page-move-course-length-to-its-own-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are making improvements to the publish workflow for providers. This PR moves the course length editing functionality to its own page, removing it from the 'Course length and salary' and the 'Course length and fees' pages.
Trello card
Changes proposed in this pull request
course.length.editing.mov
Guidance to review
Checklist