[1567] full-time part-time study change from radio buttons to checkboxes #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elceebee
force-pushed
the
1567-publish-full-time-part-time-study-change-from-radio-buttons-to-checkboxes
branch
from
1683b77 to
477c1e8
Compare
elceebee
changed the title
elceebee
force-pushed
the
1567-publish-full-time-part-time-study-change-from-radio-buttons-to-checkboxes
branch
from
477c1e8 to
8c0cc50
Compare
dcyoung-dev
reviewed
May 17, 2024
There was a problem hiding this comment.
This is way more complex than I'd have expected, there are some icky parts in this PR that are obviously from past decisions, it's scrambling my brain with the hoops you've had to jump through 🤯 good work 👌
I've left a couple of question about the specs but neither are blockers
elceebee
force-pushed
the
1567-publish-full-time-part-time-study-change-from-radio-buttons-to-checkboxes
branch
from
8c0cc50 to
7040c02
Compare
dcyoung-dev
approved these changes
May 20, 2024
elceebee
force-pushed
the
1567-publish-full-time-part-time-study-change-from-radio-buttons-to-checkboxes
branch
from
598af5b to
7731046
Compare
elceebee
force-pushed
the
1567-publish-full-time-part-time-study-change-from-radio-buttons-to-checkboxes
branch
from
7731046 to
829ab8b
Compare
tomas-stefano
approved these changes
May 20, 2024
inulty-dfe
requested changes
May 20, 2024
spec/features/publish/courses/editing_course_study_mode_spec.rb
Outdated
Show resolved
Hide resolved
elceebee
force-pushed
the
1567-publish-full-time-part-time-study-change-from-radio-buttons-to-checkboxes
branch
from
0f79b9e to
fc7f671
Compare
elceebee
deleted the
1567-publish-full-time-part-time-study-change-from-radio-buttons-to-checkboxes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
from the Trello ticket:
Following a review of historic design/research findings:
Changes proposed in this pull request
Replace radio buttons with checkboxes when selecting study pattern, for both editing a course and creating a new course.
study.pattern.checkboxes.mov
Guidance to review
Checklist