Merge pull request #4321 from DFE-Digital/dependabot/bundler/rubocop-…

…rails-2.25.1

Bump rubocop-rails from 2.25.0 to 2.25.1

Gemfile.lock

@@ -658,7 +658,7 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.26.1)
       rubocop (~> 1.61)
-    rubocop-rails (2.25.0)
+    rubocop-rails (2.25.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)

db/migrate/20190815095339_change_application_start_and_end_date_to_not_null.rb

@@ -2,7 +2,9 @@
 
 class ChangeApplicationStartAndEndDateToNotNull < ActiveRecord::Migration[5.2]
   def change
+    # rubocop:disable Rails/BulkChangeTable
     change_column_null :recruitment_cycle, :application_start_date, false
     change_column_null :recruitment_cycle, :application_end_date, false
+    # rubocop:enable Rails/BulkChangeTable
   end
 end

db/migrate/20190909105439_provider_enrichment_user_not_null.rb

@@ -14,13 +14,16 @@ def up
       pe.updated_by_user_id = some_id
       pe.save!
     end
-
+    # rubocop:disable Rails/BulkChangeTable
     change_column_null :provider_enrichment, :updated_by_user_id, false
     change_column_null :provider_enrichment, :created_by_user_id, false
+    # rubocop:enable Rails/BulkChangeTable
   end
 
   def down
+    # rubocop:disable Rails/BulkChangeTable
     change_column_null :provider_enrichment, :updated_by_user_id, true
     change_column_null :provider_enrichment, :created_by_user_id, true
+    # rubocop:enable Rails/BulkChangeTable
   end
 end

db/migrate/20210317141543_add_not_null_to_user.rb

@@ -2,7 +2,9 @@
 
 class AddNotNullToUser < ActiveRecord::Migration[6.1]
   def change
+    # rubocop:disable Rails/BulkChangeTable
     change_column_null(:user, :first_name, false)
     change_column_null(:user, :last_name, false)
+    # rubocop:enable Rails/BulkChangeTable
   end
 end