Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging conversion and transfers Cypress tests #1254

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

RichikaD
Copy link
Collaborator

@RichikaD RichikaD commented Jan 2, 2025

Context : Earlier the Conversions and Transfers Cypress tests were running in a separate projects/repositories. However as now Conversions and transfers projects are merged into one thus we want to run the Cypress tests in same repository.
The issue was that the Conversion cypess tests were written in javascript and Transfers cypress tests were written in typescript. We wanted to merge them and run together in the same repository for better picture/structure.

Resolved by following these steps:

  1. Moved all transfers typescript tests along with other required files to existing Conversions e2e folder . Named them correctly.
  2. Install Cypress
  3. Install TypeScript
  4. Set up TypeScript Configuration
  5. Configure Cypress to Use TypeScript
  6. Could run Tests written in Both JavaScript and TypeScript

Transfers conversions test

Conversion tests
Conversion filteration tests

Transfers tests
Transfers test usimng transfer url

@RichikaD
Copy link
Collaborator Author

RichikaD commented Jan 2, 2025

The Changes still needs bit refining and check if all the tests are passing
@FahadDarw

@RichikaD
Copy link
Collaborator Author

RichikaD commented Jan 7, 2025

Note: Cypress.env.json file needs to be update in local and in CI flow for transfersUrl
cc: @FahadDarw

Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)
20.9% Duplication on New Code (required ≤ 3.0%)
8 New Code Smells (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@dangood84 dangood84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure looks great!

Can also run some of the Transfers tests from this remote branch with the Transfers URL @RichikaD mentions...

Guessing some of these Transfers Cypress tests are quite old though which is why I guess some of them are failing...

Run of remote branch on my Windows DFE device

image

Run of Remote Branch on My Mac

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants