Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename application.sass.scss to application.scss #89

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Nitemaeric
Copy link
Contributor

@Nitemaeric Nitemaeric commented Jan 8, 2024

Context

We don't need the additional .sass extension.

Changes proposed in this pull request

Rename application.sass.scss to application.scss.

Guidance to review

Application CSS should still compile as usual.

Link to Trello card

https://trello.com/c/qSOonuo4/101-rename-applicationsassscss-to-applicationscss

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated or added to the Azure KeyVault

We don't need the additional .sass extension.
@Nitemaeric Nitemaeric marked this pull request as ready for review January 8, 2024 14:29
@Nitemaeric Nitemaeric requested review from a team January 8, 2024 14:29
@Nitemaeric
Copy link
Contributor Author

@Nitemaeric Nitemaeric self-assigned this Jan 8, 2024
@Nitemaeric Nitemaeric merged commit b81d390 into main Jan 8, 2024
3 checks passed
@Nitemaeric Nitemaeric deleted the dd/rename-application-sass-scss branch January 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants