Redirect users to organisations index/show after sign in #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinVoineag
changed the title
In claims we need to redirect our users to the organisations index page. Some users do have only one organisation(school) so for those users we will redirect them to the school show page, we do this via another redirect in the schools controller just to make sure a user with one school doesn't land on the organisation(school) index page. This change also affects placements where we will always redirect the user after sign in to the organisations index page.
CatalinVoineag
force-pushed
the
cv/redirect-users-to-org
branch
from
d9d4df0 to
fb5f471
Compare
gms-gs
approved these changes
Jan 8, 2024
elceebee
approved these changes
Jan 8, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In claims we need to redirect our users to the organisations index page. Some users do have only one organisation(school) so for those users we will redirect them to the school show page, we do this via another redirect in the schools controller just to make sure a user with one school doesn't land on the organisation(school) index page.
This change also affects placements where we will always redirect the user after sign in to the organisations index page, allowing placements to add their logic in their controllers
Also I didn't want to add too much logic in the application controller.
Changes proposed in this pull request
Application controller
Scholl Controller
Guidance to review
Claims:
Placements:
Screenshots
Peek.2024-01-08.13-07.mp4