Add a request spec for the "Add placement" journey

[ollietreend]

Context

Request specs are useful for covering behaviours and side effects which aren't strictly user facing.

They can be used when the scenario is difficult to reproduce in a system spec (for example, requesting paths which can't be navigated to using the UI), or where the expected behaviour can't be asserted directly from the UI (for example, to check that email or Slack notifications are triggered in response to a user's actions).

Changes proposed in this pull request

I've added request specs to cover the following "Add placement" journeys:

• School → Placements → Add placement
• Support console → School → Placements → Add placement

I've also moved the system spec for adding a placement in the support console, so the spec file sits alongside other related specs. It wasn't easy to find in its original location.

Guidance to review

No specific guidance, but...

A note on "DRY"

I recognise that the two request specs added here are very similar. I've chosen not to try and DRY-up the test into a shared example.

My reasoning behind that decision:

• There are only seven examples in common between the two specs.
• Some parts of the test are different – for example, I've used different *_path route helpers because the requests go to different controllers.
• There's potential for the two to diverge a bit – especially in the way they handle 'unhappy' paths.
  • For example, there's currently a question over how the support console should handle schools which don't have placement contact details yet.
  • Support users have access to every school, whereas regular users need to be on the users list for the school before they're allowed access. I've included test coverage of this.
• Generally speaking, I think tests work best when they're explicit and easy to read, without too much indirection or abstraction. Some people call this writing "WET" tests. But it's an art, not a science.

If anybody has strong opinions about whether I should DRY-up these tests or not, I'm happy to hear them!

Link to Trello card

https://trello.com/c/nvYNw8IB/543-add-test-coverage-for-add-placement-journey-edge-cases-and-side-effects