Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closing date disclaimer banners #822

Merged

Conversation

Nitemaeric
Copy link
Contributor

@Nitemaeric Nitemaeric commented Jul 4, 2024

Context

We want to highlight the closing date of submitting claims as we near the closing date.

Changes proposed in this pull request

  • Add closing data disclaimer banner to start page and school's claims pages (Users and Support Users).
  • Correct closing date time formatting.

Guidance to review

  • Banner should only appear on /, /schools/:school_id/claims, and /support/schools/:school_id/claims pages.

Screenshots

CleanShot 2024-07-08 at 10 03 11

@Nitemaeric Nitemaeric force-pushed the dd/claims-closing-date-banner-and-date-format-fixes branch from 2585d0a to 20d0440 Compare July 4, 2024 14:26
@Nitemaeric Nitemaeric self-assigned this Jul 4, 2024
@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Review app track and pay deployed to https://track-and-pay-822.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-822.test.teacherservices.cloud was deleted

Also correct closing date time formatting.
@Nitemaeric Nitemaeric force-pushed the dd/claims-closing-date-banner-and-date-format-fixes branch from 20d0440 to 9f8f1ce Compare July 8, 2024 09:01
@Nitemaeric Nitemaeric marked this pull request as ready for review July 8, 2024 09:03
@Nitemaeric Nitemaeric requested a review from a team as a code owner July 8, 2024 09:03
@Nitemaeric Nitemaeric merged commit f553775 into main Jul 8, 2024
8 checks passed
@Nitemaeric Nitemaeric deleted the dd/claims-closing-date-banner-and-date-format-fixes branch July 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants