-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support settings #821
Add support settings #821
Conversation
Review app track and pay deployed to https://track-and-pay-821.test.teacherservices.cloud was deleted |
dbb9848
to
1595e95
Compare
1595e95
to
4c889b1
Compare
4c889b1
to
9579ac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Is this error because of the review app?
Peek.2024-07-05.14-19.mp4
Yeah, it's because there are no Claims in the db. :/ |
9e09ec0
to
ea77efb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @Nitemaeric.
Context
We want to be able to visualise what emails we have.
Changes proposed in this pull request
Guidance to review
Does @DFE-Digital/school-placements want this too? I can add it in.
I have opted to NOT using the default
/rails/mailers
path for listing out the emails, for 2 reasons:Link to Trello card
https://trello.com/c/5qfMu8ZG/544-look-into-getting-email-previews-live
Screenshots