Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support settings #821

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Add support settings #821

merged 4 commits into from
Jul 8, 2024

Conversation

Nitemaeric
Copy link
Contributor

@Nitemaeric Nitemaeric commented Jul 3, 2024

Context

We want to be able to visualise what emails we have.

Changes proposed in this pull request

  • Add a Settings page to Claims support console.
  • Add a link to Background Jobs.
  • Add a page for listing out emails.

Guidance to review

Does @DFE-Digital/school-placements want this too? I can add it in.

I have opted to NOT using the default /rails/mailers path for listing out the emails, for 2 reasons:

  1. I want the experience to align with the look at feel of the rest of the Support console.
  2. I want to filter emails by service.

Link to Trello card

https://trello.com/c/5qfMu8ZG/544-look-into-getting-email-previews-live

Screenshots

Page Screenshot
Settings image
Emails list image
Rails mailer preview image

@Nitemaeric Nitemaeric self-assigned this Jul 3, 2024
@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Review app track and pay deployed to https://track-and-pay-821.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-821.test.teacherservices.cloud was deleted

@Nitemaeric Nitemaeric force-pushed the dd/add-support-settings branch from 4c889b1 to 9579ac1 Compare July 4, 2024 11:49
@Nitemaeric Nitemaeric marked this pull request as ready for review July 4, 2024 11:49
@Nitemaeric Nitemaeric requested review from a team as code owners July 4, 2024 11:49
@Nitemaeric Nitemaeric changed the title Dd/add support settings Add support settings Jul 4, 2024
Copy link
Contributor

@CatalinVoineag CatalinVoineag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Is this error because of the review app?

Peek.2024-07-05.14-19.mp4

@Nitemaeric
Copy link
Contributor Author

Code looks good. Is this error because of the review app?

Peek.2024-07-05.14-19.mp4

Yeah, it's because there are no Claims in the db. :/

Copy link
Contributor

@ollietreend ollietreend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @Nitemaeric.

@Nitemaeric Nitemaeric merged commit 72d7644 into main Jul 8, 2024
8 checks passed
@Nitemaeric Nitemaeric deleted the dd/add-support-settings branch July 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants