De-duplicate wizard step partials #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kizr
force-pushed
the
ba/deduplicate_wizard_step_partials
branch
from
ea1d8ea to
db7738b
Compare
ollietreend
reviewed
Jul 3, 2024
ollietreend
reviewed
Jul 3, 2024
ollietreend
approved these changes
Jul 4, 2024
Nitemaeric
reviewed
Jul 5, 2024
Kizr
force-pushed
the
ba/deduplicate_wizard_step_partials
branch
from
20fdab4 to
9600e11
Compare
Nitemaeric
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are duplicating views for wizards when the journey remains the same, we feel that these views/steps are coupled to the logic of the wizard and should be treated as such
Changes proposed in this pull request
Guidance to review
Link to Trello card
Deduplicate wizard step partials