Clean up User association definitions

[Nitemaeric]

Context

The associations were difficult to visually parse.

Changes proposed in this pull request

As inlining these does not go against our RuboCop lint rules, bring the definitions inline.

Guidance to review

Does it read nicer? 😄

Link to Trello card

Things to check

• If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
• This code does not rely on migrations in the same Pull Request
• If this code includes a migration adding or changing columns, it also backfills existing records for consistency
• If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
• API release notes have been updated if necessary
• If it adds a significant user-facing change, is it documented in the CHANGELOG?
• Required environment variables have been updated or added to the Azure KeyVault

Screenshots

[elceebee]

I find the first way easier to read personally. The extra space on line 21 between schools, and through is especially jarring for me to read. :)

In general, I don't think we should reformat code like this. I could change it tomorrow because I think it reads easier over multiple lines and we could end up in an infinite loop of reformatting.