Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Capybara to use rack_test driver by default in system specs #51

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Nitemaeric
Copy link
Contributor

Context

We want to configure Capybara to use the :rack_test driver by default and the :chrome_headless driver when js is required.

Changes proposed in this pull request

Add Capybara configuration.

Guidance to review

BAT reference can be found here: https://github.com/DFE-Digital/apply-for-teacher-training/blob/dd2212514ff076ddb6b423bdfac31615a7013406/spec/support/capybara.rb

Link to Trello card

https://trello.com/c/Bq7BJB6G/85-add-capybara-configuration?filter=label:Dev

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated or added to the Azure KeyVault

Screenshots

Copy link
Contributor

@CatalinVoineag CatalinVoineag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this on local, works as expected 👍🏻

Copy link
Contributor

@JamieCleare2525 JamieCleare2525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make some of my tests quick config change on my PR. But happy that this works.

@Nitemaeric Nitemaeric merged commit a485bee into main Dec 22, 2023
4 checks passed
@Nitemaeric Nitemaeric deleted the dd/configure-capybara branch December 22, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants