Implement claim revisions on claim form #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
04be47a to
7e10084
Compare
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
2 times, most recently
from
fd08e16 to
c9b9315
Compare
CatalinVoineag
added
the
deploy
CatalinVoineag
changed the title
Deployments
|
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
c9b9315 to
5d19193
Compare
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
5d19193 to
e9fc22b
Compare
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
e9fc22b to
5033f1c
Compare
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
5033f1c to
59ec911
Compare
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
59ec911 to
5eba415
Compare
gms-gs
reviewed
May 1, 2024
| end | ||
|
|
||
| def authorize_claim | ||
| authorize @claim || Claims::Claim | ||
| end | ||
|
|
||
| def create_revision? |
There was a problem hiding this comment.
This seems to be duplicated in a few places. Could we put this into a concern or service to DRY it up?
gms-gs
approved these changes
May 1, 2024
|
After discussion, we've decided to try a different approach. |
Nitemaeric
reviewed
May 1, 2024
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
2 times, most recently
from
e6cadba to
f15f39b
Compare
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
f15f39b to
80b38e8
Compare
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
80b38e8 to
b218e8a
Compare
Nitemaeric
reviewed
May 2, 2024
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
b218e8a to
3e640c6
Compare
Nitemaeric
reviewed
May 2, 2024
| @@ -0,0 +1,28 @@ | |||
| class Claims::Claim::UpdateDraft < Claims::Claim::CreateDraft | |||
There was a problem hiding this comment.
This service does the same btw 😛
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
3e640c6 to
6952488
Compare
claim record on the check page when creating a claim. Issues were found when the user would click the back buttons to go back to the check page after completing half their changes. The changes they did were being saved. Even if they backed off from doing them. To solve this issue and many others, we are implementing a revision system on the claim. Creating a revision every time a user wants to edit a claim from the check page. If they back off half way through their changes we revert back to the last valid claim revision. This implementation will increase the audit records and possibly pollute some of them with `system changes` i.e. changes to `previous_revision_id` or `next_revision_id` which the user doesn't care about. For the draft claim This should fix the issue where a support user edits a draft claim and with every edit, the draft claim is updated for everyone. This will only `update` the draft claim when the support user actually clicks `Update claim`. They way this works is by using the `internal_draft` status. A generated revision starts with `internal_draft` as its status and is changed to draft when the support user finishes editing the draft claim. The previous revision is then set to `internal_draft`, to not show more than 1 claim per reference.
CatalinVoineag
force-pushed
the
cv/refactor-claims-form
branch
from
6952488 to
0682645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In testing the claim form we concluded that we cannot edit the same claim record on the check page when creating a claim.Issues were found when the user would click the back buttons to go back to the check page after completing half their changes. The changes they did were being saved. Even if they backed off from doing them.
To solve this issue and many others, we are implementing a revision system on the claim.
Creating a revision every time a user wants to edit a claim from the check page. If they back off half way through their changes we revert back to the last valid claim revision.
This implementation will increase the audit records and possibly pollute some of them with
system changesi.e. changes toprevious_revision_idwhich the user doesn't care about.This should fix the issue where a support user edits a draft claim and with every edit, the draft claim is updated for everyone.
The way this works is by using the
internal_draftstatus. A generated revision starts withinternal_draftas its status and is changed to draft when the support user finishes editing the draft claim. The previous revision is then set tointernal_draft, to not show more than 1 claim per reference.Changes proposed in this pull request
Claim model
Claim form
Claim support form
Guidance to review
Normal User:
Support User:
Do the same things as the normal user
Edit a draft claim
Edit a draft claim and click back buttons
Your changes to the draft claim should only be saved after you click
Update claimScreenshots
Peek.2024-04-24.11-00.mp4