Remove deprecation notice from tests #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following deprecation notice was being shown when running the RSpec test suite: ``` Rails 7.1 has deprecated the singular fixture_path in favour of an array ``` We should set `config.fixture_paths = []` instead of `config.fixture_path`. However, we don't actually use ActiveRecord fixtures. We prefer to use FactoryBot. So I've fixed the deprecation, but then have commented out the line since it's not something we use. If we need to enable it in the future, I've fixed the deprecation notice so we should be able to simply uncomment the line.
JamieCleare2525
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following deprecation notice was being shown when running the RSpec test suite:
We should set
config.fixture_paths = []instead ofconfig.fixture_path.However, we don't actually use ActiveRecord fixtures. We prefer to use FactoryBot. So I've fixed the deprecation, but then have commented out the line since it's not something we use.
If we need to enable it in the future, I've fixed the deprecation notice so we should be able to simply uncomment the line.