Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk-components and govuk-frontend #29

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

JamieCleare2525
Copy link
Contributor

@JamieCleare2525 JamieCleare2525 commented Dec 14, 2023

Context

Changes proposed in this pull request

Followed the Release notes to bump the versions of govuk-components gem and govuk-frontend package to latest versions.

Guidance to review

  • Run yarn install
  • Nothing should break and everything should look exactly how it did before.

Link to Trello card

https://trello.com/c/cqw6yaRb/68-upgrade-govuk-frontend-and-govuk-components-to-v500

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated or added to the Azure KeyVault

Screenshots

screencapture-localhost-3000-personas-2023-12-14-15_35_52

@JamieCleare2525 JamieCleare2525 self-assigned this Dec 14, 2023
@JamieCleare2525 JamieCleare2525 changed the title WIP Bump govuk-components and govuk-frontend Dec 14, 2023
@JamieCleare2525 JamieCleare2525 marked this pull request as ready for review December 14, 2023 15:37
Copy link
Contributor

@CatalinVoineag CatalinVoineag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this on local, works as expected 👍🏻

Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally, all good!

@JamieCleare2525 JamieCleare2525 merged commit 36f92be into main Dec 14, 2023
4 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/bump_govuk_gems branch December 14, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants