Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty state for user lists in placements #169

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

elceebee
Copy link
Contributor

Context

Support users in placements should see an empty state when viewing an organisation with no users

Changes proposed in this pull request

adds empty state to user lists (providers and schools)

Guidance to review

Sign in as placements Colin
Add an organisation
Look at that organisation's users list
You should see the empty state "There are no users for..." instead of an empyt table.

Link to Trello card

None

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated or added to the Azure KeyVault

Screenshots

image

@elceebee elceebee requested a review from a team as a code owner January 26, 2024 18:15
@elceebee elceebee self-assigned this Jan 29, 2024
@elceebee elceebee merged commit 5b105e5 into main Jan 29, 2024
6 checks passed
@elceebee elceebee deleted the lb/add-empty-state-to-user-lists-in-placements branch January 29, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants