Add translated error message for provider code taken

DFE-Digital · Dec 22, 2023 · 3b78a77 · 3b78a77
1 parent 06df3db
commit 3b78a77
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/app/models/provider.rb b/app/models/provider.rb
@@ -16,6 +16,8 @@ class Provider < ApplicationRecord
   validates :provider_code,
             uniqueness: {
               case_sensitive: false,
-              message: "Provider already exists!"
+              message: I18n.t(
+                ".activerecord.errors.models.provider.attributes.provider_code.taken"
+              )
             }
 end
diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -1,4 +1,11 @@
 en:
+  activerecord:
+    errors:
+      models:
+        provider:
+          attributes:
+            provider_code:
+              taken: Provider already exists
   organisations: Organisations
   schools: Schools
   providers: Providers

diff --git a/spec/models/provider_spec.rb b/spec/models/provider_spec.rb
@@ -21,7 +21,7 @@
     it do
       is_expected.to validate_uniqueness_of(
         :provider_code,
-      ).case_insensitive.with_message("Provider already exists!")
+      ).case_insensitive.with_message("Provider already exists")
     end
   end
 end
diff --git a/spec/system/placements/providers/support_user_adds_a_provider_spec.rb b/spec/system/placements/providers/support_user_adds_a_provider_spec.rb
@@ -68,7 +68,7 @@
     then_i_see_a_dropdown_item_for("Provider 1")
     when_i_click_the_dropdown_item_for("Provider 1")
     and_i_click_continue
-    then_i_see_an_error("Provider already exists!")
+    then_i_see_an_error("Provider already exists")
   end
 
   private