Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify tests to test the actual factory rather than a mock of the factory #23

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Modify tests to test the actual factory rather than a mock of the factory #23

merged 6 commits into from
Nov 18, 2024

Conversation

CathLass
Copy link
Collaborator

@CathLass CathLass commented Nov 6, 2024

Two tests fail - I'd like to remove the methods that they're testing if we're not using them

@spanersoraferty
Copy link
Collaborator

I've removed the unused methods btw

@CathLass CathLass marked this pull request as ready for review November 18, 2024 08:23
@CathLass CathLass merged commit e03bc9c into main Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spanersoraferty spanersoraferty spanersoraferty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CathLass @spanersoraferty @spencerohegartyDfE