Scrape custom metrics #1452
Merged
Scrape custom metrics #1452
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
saliceti
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Scrape custom metrics that are exported for gitapi,
which can then be used in dashboards and alerting
https://trello.com/c/Zlih3dRZ/1889-scrape-custom-metrics
Changes proposed in this pull request
Add enable_prometheus_monitoring to application deployments and set for each env
Guidance to review
make development_aks terraform-plan IMAGE_TAG=x
This has been deployed manually to dev & test envs and metrics are available in test prometheus (look for metrics starting with api)
Some metrics (e.g. hangfire) are possibly not being exported, and that may need follow up with the dev team.