Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix to apply candidate sync job #1433

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

martyn-w
Copy link
Contributor

@martyn-w martyn-w commented Jun 6, 2024

This corrects a bug introduced by the upgrade of the Flurl.Http library in PR #1383 which changed the default json parsing library from Newtonsoft.Json to System.Text.Json. A consequence of this bug was that parsing of the Apply Candidates API fails and so synchronisation between Apply and the CRM failed.

This fix imports the library Flurl.Http.Newtonsoft and adds calls to FlurlHttp.Clients.UseNewtonsoft() to enforce usage of the Newtonsoft serializer.

For more information, see:

@martyn-w martyn-w temporarily deployed to development_aks June 6, 2024 11:06 — with GitHub Actions Inactive
@github-actions github-actions bot added VisualCSharp Visual C # Test Test scripts and harnesses labels Jun 6, 2024
Copy link

sonarqubecloud bot commented Jun 6, 2024

@martyn-w martyn-w temporarily deployed to development_aks June 6, 2024 11:17 — with GitHub Actions Inactive
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@martyn-w martyn-w merged commit cac7e8b into master Jun 6, 2024
11 checks passed
@martyn-w martyn-w deleted the bugfix-apply-candidate-sync-job branch June 6, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test scripts and harnesses VisualCSharp Visual C #
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants