Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[909] Remove paas Github environments #1338

Merged
merged 4 commits into from
Jan 18, 2024
Merged

[909] Remove paas Github environments #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54d0b47
Remove paas Github environments
saliceti Jan 18, 2024
2056b3b
Set up java for sonarcloud
saliceti Jan 18, 2024
830be3e
Update dotnet-sonarscanner to 5.15.0
saliceti Jan 18, 2024
0e21227
Sonarcloud fix indentation
saliceti Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
azure-credentials: ${{ secrets.AZURE_CREDENTIALS }}

- name: Slack Release Notification
if: steps.tag_id.outputs.release_id && github.event.inputs.environment == 'Production'
if: steps.tag_id.outputs.release_id && github.event.inputs.environment == 'production_aks'
uses: rtCamp/action-slack-notify@master
env:
SLACK_COLOR: ${{env.SLACK_SUCCESS}}
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ jobs:
- name: set-up-environment
uses: DFE-Digital/github-actions/set-up-environment@master

- uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 21

- uses: Azure/login@v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
Expand All @@ -38,7 +43,7 @@ jobs:
dotnet-version: '7.0'

- name: Install dotnet-sonarscanner
run: dotnet tool install --global dotnet-sonarscanner --version 5.9.1
run: dotnet tool install --global dotnet-sonarscanner --version 5.15.0

- name: Install dependencies
run: dotnet restore
Expand Down Expand Up @@ -70,9 +75,9 @@ jobs:
" \
/d:sonar.verbose=true \
/d:sonar.log.level="DEBUG"
dotnet build
dotnet test --no-build --logger:trx -e:CollectCoverage=true -e:CoverletOutputFormat=opencover
dotnet sonarscanner end /d:sonar.login="${{ steps.fetch-secrets.outputs.SONAR-TOKEN }}"
dotnet build
dotnet test --no-build --logger:trx -e:CollectCoverage=true -e:CoverletOutputFormat=opencover
dotnet sonarscanner end /d:sonar.login="${{ steps.fetch-secrets.outputs.SONAR-TOKEN }}"

- name: Slack Notification
if: failure() && github.ref == 'refs/heads/master'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trello.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
name: Link Trello card to this PR
if: "!contains( 'dependabot[bot] snyk-bot' , github.actor )"
runs-on: ubuntu-latest
environment: Development
environment: development_aks
steps:
- uses: Azure/login@v1
with:
Expand Down
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,15 @@ The API is deployed to [AKS](https://github.com/DFE-Digital/teacher-services-clo

| Environment | ASP.NET Core Environment | URL |
| ----------------------- | ------------------------ | ----------------------------------------------------------------- |
| development (AKS) | staging | https://getintoteachingapi-development.test.teacherservices.cloud/|
| test (AKS) | staging | https://getintoteachingapi-test.test.teacherservices.cloud/ |
| production (AKS) | production | https://getintoteachingapi-production.teacherservices.cloud/ |
| development (local) | development | localhost |
| test (local) | test | n/a |
| development (AKS) | Staging | https://getintoteachingapi-development.test.teacherservices.cloud/|
| test (AKS) | Staging | https://getintoteachingapi-test.test.teacherservices.cloud/ |
| production (AKS) | Production | https://getintoteachingapi-production.teacherservices.cloud/ |
| development (local) | Development | localhost |
| test (local) | Test | n/a |

### Process

When you merge a branch to `master` it will automatically be deployed to the [development](#environments) and [test](#environments) environments via GitHub Actions and a tagged release will be created (the tag will use the PR number). You can then test the changes using the corresponding dev/test environments of the other GiT services. Once you're happy and want to ship to [production](#environments) you need to note the tag of your release and go to the `Manual Release` GitHub Action; from there you can select `Run workflow`, choose the `Production` environment and enter your release number.
When you merge a branch to `master` it will automatically be deployed to the [development](#environments) and [test](#environments) environments via GitHub Actions and a tagged release will be created (the tag will use the PR number). You can then test the changes using the corresponding dev/test environments of the other GiT services. Once you're happy and want to ship to [production](#environments) you need to note the tag of your release and go to the `Manual Release` GitHub Action; from there you can select `Run workflow`, choose the `production_aks` environment and enter your release number.

### Rollbacks

Expand Down
Loading