Set DSN to "" in tests

Using an env var does not work as "" is treated as NULL
DFE-Digital · May 23, 2024 · 179f677 · 179f677
1 parent 09ea274
commit 179f677
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/.github/common_environment.yml b/.github/common_environment.yml
@@ -5,5 +5,3 @@
   SLACK_ICON:            https://raw.githubusercontent.com/DFE-Digital/get-into-teaching-api/master/.github/image.png?size=48
   SLACK_USERNAME:        GiT Workflows
   SLACK_FOOTER:          Get Into Teaching API Service
-  Sentry__Dsn:           ""       
-# NB the Sentry__Dsn variable is case-sensitive
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -42,8 +42,6 @@ jobs:
       run: docker-compose up -d
 
     - name: Test
-      env:
-        Sentry__Dsn: ""
       run: dotnet test --no-restore --verbosity normal
 
     - name: Lint Dockerfile

diff --git a/GetIntoTeachingApi/env.test b/GetIntoTeachingApi/env.test
@@ -1,2 +1 @@
 APPLY_CANDIDATE_API_URL=https://sandbox.apply-for-teacher-training.service.gov.uk/candidate-api/v1.2
-Sentry__Dsn=""
diff --git a/GetIntoTeachingApiTests/Helpers/ContractTestGitWebApplicationFactory.cs b/GetIntoTeachingApiTests/Helpers/ContractTestGitWebApplicationFactory.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 using AspNetCoreRateLimit;
 using GetIntoTeachingApi.Adapters;
@@ -25,6 +25,8 @@ public ContractTestGitWebApplicationFactory(ContractTestState state)
 
         protected override void ConfigureWebHost(IWebHostBuilder builder)
         {
+            builder.UseSentry(dsn: "");
+
             builder.ConfigureServices(services =>
             {
                 // Use in-memory rate limit counters for tests.

diff --git a/GetIntoTeachingApiTests/Helpers/GitWebApplicationFactory.cs b/GetIntoTeachingApiTests/Helpers/GitWebApplicationFactory.cs
@@ -12,6 +12,8 @@ public class GitWebApplicationFactory<TStartup>
     {
         protected override void ConfigureWebHost(IWebHostBuilder builder)
         {
+            builder.UseSentry(dsn: "");
+
             builder.ConfigureServices(services =>
             {
                 // Remove Redis rate limiting.
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		APPLY_CANDIDATE_API_URL=https://sandbox.apply-for-teacher-training.service.gov.uk/candidate-api/v1.2
		Sentry__Dsn=""