Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessing Check answers page without a NINO #761

Merged
merged 1 commit into from
Nov 10, 2023

Fix accessing Check answers page without a NINO

9e3508e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix accessing Check answers page without a NINO #761

Fix accessing Check answers page without a NINO
9e3508e
Select commit
Loading
Failed to load commit list.
GitHub Actions / End-to-end test results succeeded Nov 10, 2023 in 0s

End-to-end test results ✅

Tests passed successfully

✅ dotnet-authserver/tests/TeacherIdentity.AuthServer.EndToEndTests/TestResults/_fv-az1022-255_2023-11-10_14_05_42.trx

66 tests were completed in 65s with 66 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TeacherIdentity.AuthServer.EndToEndTests.Account 4✅ 5s
TeacherIdentity.AuthServer.EndToEndTests.Api 4✅ 1s
TeacherIdentity.AuthServer.EndToEndTests.Elevate 4✅ 4s
TeacherIdentity.AuthServer.EndToEndTests.Register 22✅ 24s
TeacherIdentity.AuthServer.EndToEndTests.SignIn 5✅ 2s
TeacherIdentity.AuthServer.EndToEndTests.SignOut 4✅ 2s
TeacherIdentity.AuthServer.EndToEndTests.TrnTokenSignInJourney 23✅ 15s

✅ TeacherIdentity.AuthServer.EndToEndTests.Account

✅ AccessAccountPageDirectlyWithoutClientSignIn
✅ AccessAccountPageFromClient
✅ ChangeOfficialDateOfBirth
✅ ChangeOfficialName

✅ TeacherIdentity.AuthServer.EndToEndTests.Api

✅ GetTokenViaClientCredentialsWithReadScope_CanCallReadSupportEndpointSuccessfully
✅ GetTokenViaClientCredentialsWithWriteScope_CanCallWriteSupportEndpointSuccessfully
✅ SignInWithUserReadScope_CanCallReadSupportEndpointSuccessfully
✅ SignInWithUserWriteScope_CanCallWriteSupportEndpointSuccessfully

✅ TeacherIdentity.AuthServer.EndToEndTests.Elevate

✅ AlreadySignedInUserWithLowVerificationLevel_IsRedirectedToElevateJourney
✅ UserSignsInWithLowVerificationLevel_IsRedirectedToElevateJourneyAndCompletesSuccessfully
✅ UserSignsInWithLowVerificationLevel_IsRedirectedToElevateJourneyButTrnNotFound(trnRequirementType: Optional, expectContinueButtonOnCompletePage: True)
✅ UserSignsInWithLowVerificationLevel_IsRedirectedToElevateJourneyButTrnNotFound(trnRequirementType: Required, expectContinueButtonOnCompletePage: False)

✅ TeacherIdentity.AuthServer.EndToEndTests.Register

✅ NewUser_WithInstitutionEmail_CanRegister(useInstitutionEmail: False)
✅ NewUser_WithInstitutionEmail_CanRegister(useInstitutionEmail: True)
✅ NewUser_WithoutTrnLookup_CanRegister
✅ NewUser_WithTrnLookup_MatchingExistingAccount_VerifiesExistingAccountEmailAndCanSignInSuccessfully(trnRequirement: Optional)
✅ NewUser_WithTrnLookup_MatchingExistingAccount_VerifiesExistingAccountEmailAndCanSignInSuccessfully(trnRequirement: Required)
✅ NewUser_WithTrnLookup_TrnFound_CanRegister(trnRequirement: Optional)
✅ NewUser_WithTrnLookup_TrnFound_CanRegister(trnRequirement: Required)
✅ NewUser_WithTrnLookup_TrnFoundDifferentName_UpdatesNameAndCanRegister
✅ NewUser_WithTrnLookup_TrnNotFound_CanRegister
✅ NewUser_WithTrnLookup_TrnNotFound_CanRegister_StrictTrnMatchPolicy
✅ User_WithEmailAlreadyExists_SignsInExistingUser(additionalScope: "dqt:read", trnRequirement: Optional)
✅ User_WithEmailAlreadyExists_SignsInExistingUser(additionalScope: "dqt:read", trnRequirement: Required)
✅ User_WithEmailAlreadyExists_SignsInExistingUser(additionalScope: null, trnRequirement: null)
✅ User_WithMatchingNameAndDob_SignsInExistingUserFromEmail(additionalScope: "dqt:read", trnRequirement: Optional)
✅ User_WithMatchingNameAndDob_SignsInExistingUserFromEmail(additionalScope: "dqt:read", trnRequirement: Required)
✅ User_WithMatchingNameAndDob_SignsInExistingUserFromEmail(additionalScope: null, trnRequirement: null)
✅ User_WithMatchingNameAndDob_SignsInExistingUserFromMobilePhone(additionalScope: "dqt:read", trnRequirement: Optional)
✅ User_WithMatchingNameAndDob_SignsInExistingUserFromMobilePhone(additionalScope: "dqt:read", trnRequirement: Required)
✅ User_WithMatchingNameAndDob_SignsInExistingUserFromMobilePhone(additionalScope: null, trnRequirement: null)
✅ User_WithMobileAlreadyExists_SignsInExistingUser(additionalScope: "dqt:read", trnRequirement: Optional)
✅ User_WithMobileAlreadyExists_SignsInExistingUser(additionalScope: "dqt:read", trnRequirement: Required)
✅ User_WithMobileAlreadyExists_SignsInExistingUser(additionalScope: null, trnRequirement: null)

✅ TeacherIdentity.AuthServer.EndToEndTests.SignIn

✅ ExistingTeacherUser_AlreadySignedIn_SkipsEmailAndPinAndShowsCorrectConfirmationPage
✅ FirstRequestToProtectedAreaOfSiteForUserAlreadySignedInViaOAuth_IssuesUserSignedInEvent
✅ StaffUser_CanSignInSuccessfullyWithEmailAndPin
✅ StaffUser_CanSignInToAdminPageSuccessfullyWithEmailAndPin
✅ StaffUser_MissingPermission_GetsForbiddenError

✅ TeacherIdentity.AuthServer.EndToEndTests.SignOut

✅ SignOutFromClient
✅ SignOutFromCompletePage
✅ SignOutFromIdDirectly
✅ SignOutViaAccountPageWithClientContext

✅ TeacherIdentity.AuthServer.EndToEndTests.TrnTokenSignInJourney

✅ ExistingUserNoTrn_ValidTrnTokenMatchingEmail_SignsInUserUpdatesTrnInvalidatesToken
✅ ExistingUserNoTrn_ValidTrnTokenMatchingEmailNotMatchingName_SignsInUserUpdatesTrnAndNameInvalidatesToken
✅ ExistingUserSignsIn_ValidTrnTokenMatchingTrn_SignInAndInvalidatesToken
✅ ExistingUserSignsIn_ValidTrnTokenNotMatchingTrn_SignInAndIgnoreToken
✅ ExistingUserSignsInNoTrn_ValidTrnToken_AssignsToken
✅ ExistingUserSignsInNoTrn_ValidTrnTokenDifferentName_AssignsTokenUpdatesName
✅ ExistingUserWithTrn_ValidTrnTokenMatchingEmailAndTrn_SignsInUserInvalidatesToken
✅ ExistingUserWithTrn_ValidTrnTokenNotMatchingTrn_StartsCoreSignInJourney
✅ NewTeacherUser_WithTrnToken_CreatesUserAndCompletesFlow
✅ NewTeacherUser_WithTrnTokenChangesEmail_CreatesUserAndCompletesFlow
✅ NewTeacherUser_WithTrnTokenChangesToInstitutionEmail_CreatesUserAndCompletesFlow(useInstitutionEmail: False)
✅ NewTeacherUser_WithTrnTokenChangesToInstitutionEmail_CreatesUserAndCompletesFlow(useInstitutionEmail: True)
✅ NewTeacherUser_WithTrnTokenForDqtRecordWithMissingDateOfBirth_CreatesUserAndCompletesFlow
✅ NewUserRegisters_ValidTrnTokenPhoneVerificationMatchesExistingAccountMatchingTrn_InvalidatesTrnToken
✅ NewUserRegisters_ValidTrnTokenPhoneVerificationMatchesExistingAccountNotMatchingTrn_IgnoresTrnToken
✅ NewUserRegisters_ValidTrnTokenPhoneVerificationMatchesExistingAccountNoTrn_AssignsTrnToken
✅ NewUserSignsIn_ValidTrnTokenMatchingExistingAccountNameAndDoBNoTrn_SignInAndAssignTrnToken
✅ NewUserSignsIn_ValidTrnTokenMatchingExistingAccountNameAndDoBWithNotMatchingTrn_ExistingAccountNotChosen_ContinuesTrnTokenSignInJourney
✅ NewUserSignsIn_ValidTrnTokenMatchingExistingAccountNameAndDoBWithNotMatchingTrn_SignInAndIgnoreTrnToken
✅ SignedInUser_ValidTrnTokenNotMatchingEmail_StartsTrnTokenJourney
✅ SignedInUserNoTrn_ValidTrnTokenMatchingEmail_UpdatesUserTrnInvalidatesToken
✅ SignedInUserWithTrn_ValidTrnTokenMatchingEmailAndTrn_InvalidatesToken
✅ SignedInUserWithTrn_ValidTrnTokenMatchingEmailNotMatchingTrn_IgnoresTrnToken
View more details on GitHub Actions