Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the deadLetterErrorDescription is within the allowed size #758

Merged
merged 1 commit into from
Nov 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ namespace TeacherIdentity.AuthServer.Notifications.WebHooks;

public sealed class ServiceBusWebHookNotificationPublisher : WebHookNotificationPublisher, IAsyncDisposable, IHostedService
{
private const int MaxDeadLetterDescriptionLength = 4096;

private static readonly TimeSpan[] _retryIntervals = new[]
{
TimeSpan.FromSeconds(30),
Expand Down Expand Up @@ -110,7 +112,10 @@ private async Task ProcessMessage(ProcessMessageEventArgs arg)
{
_logger.LogError(ex, "Failed processing message after {RetryNumber} retries.", retryNumber);

await arg.DeadLetterMessageAsync(message, deadLetterReason: "Could not deliver web hook", deadLetterErrorDescription: ex.ToString());
await arg.DeadLetterMessageAsync(
message,
deadLetterReason: "Could not deliver web hook",
deadLetterErrorDescription: ex.ToString().Truncate(MaxDeadLetterDescriptionLength));
return;
}

Expand Down Expand Up @@ -155,3 +160,20 @@ private class ApplicationPropertiesKeys
public const string RetryNumber = "RetryNumber";
}
}

file static class StringExtensions
{
private const string TruncatedSuffix = "...";

public static string Truncate(this string str, int length)
{
if (length <= TruncatedSuffix.Length)
{
throw new ArgumentOutOfRangeException(nameof(length));
}

return str.Length > length ?
str[..(length - TruncatedSuffix.Length + 1)] + TruncatedSuffix :
str;
}
}
Loading